Skip to content

Comments

Feature/pipettor#72

Closed
sixym3 wants to merge 9 commits intoNSLS2:humblefrom
sixym3:feature/pipettor
Closed

Feature/pipettor#72
sixym3 wants to merge 9 commits intoNSLS2:humblefrom
sixym3:feature/pipettor

Conversation

@sixym3
Copy link

@sixym3 sixym3 commented Sep 23, 2025

Added pipettor driver and descriptions.

bondada-a and others added 4 commits September 19, 2025 13:45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm content with this approach. Makes sense during development and planned deprecation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good refactor.

@maffettone
Copy link
Contributor

One comment, I noted after approval. It seems that the submodules are dead links...

@sixym3
Copy link
Author

sixym3 commented Sep 25, 2025

One comment, I noted after approval. It seems that the submodules are dead links...

I am using the setup.bash to git clone repos in the ros2.repos and the driver.repos, not sure if that is what you are referring to. I can have the empty submodules folders removed if you prefer?

@maffettone
Copy link
Contributor

Following on from our discussion, let's either use the vcs approach or git submodules, but not both. I like the vcs approach.

@maffettone
Copy link
Contributor

maffettone commented Oct 2, 2025

Markdown errors from super linter

  /github/workspace/README.md:32:20 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
  /github/workspace/README.md:104:259 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]
  /github/workspace/src/end_effectors/README.md:20:45 MD034/no-bare-urls Bare URL used [Context: "https://github.com/bondada-a/r..."]

sixym3 and others added 3 commits October 3, 2025 13:13
…ilds on version tags, marked docker folder and artifacts as being Depricated, and updated README.md to reflect what is actively being developed
@sixym3
Copy link
Author

sixym3 commented Oct 3, 2025

Added workflow to automatically build image and push to ghcr.io on version tag. Fixed Lint Errors. Removed empty gitsubmodules but it seems the humble branch already has those changes. Streamlined deployment to use setup.sh and build.sh.

@sixym3
Copy link
Author

sixym3 commented Oct 10, 2025

Close to use feature/pipettor_lint branch

@sixym3 sixym3 closed this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants